Does not ask for confirmation on deleting one or subsequent messages on last message #5361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
|
✅ No security or compliance issues detected. Reviewed everything up to dd5e491. Security Overview
Detected Code Changes
Reply to this PR with |
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Hey @liwilliam2021 I noticed that this PR is pointing to the In that case you can probably wait until #5359 gets merged and you can point this PR at main. |
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Changes Requested]
in Roo Code Roadmap
hannesrudolph
added
PR - Changes Requested
and removed
PR - Needs Preliminary Review
labels
Contributor
Author
Yes that was the intention! Will wait |
dosubot
bot
added
size:XL
github-project-automation
bot
moved this from PR [Changes Requested]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pro: it's less annoying to delete the last message, it doesn't make sense to ask the user if they want to delete one message or all messages if it's the last message
Cons: maybe we want to force a confirmation. If so, I can also add a separate panel in this case
Important
Skips confirmation dialog for last message deletion/editing in
webviewMessageHandler.ts, defaulting to "just this message" option, with updated tests inClineProvider.spec.ts.handleMessageModificationsOperationinwebviewMessageHandler.ts.ClineProvider.spec.tsto verify new behavior for last message deletion and editing.This description was created by
for dd5e491. You can customize this summary. It will automatically update as commits are pushed.